Open
Conversation
Sometimes, a UnicodeDecodeError was thrown due to invalid characters. With 'replace', these invalid characters are instead converted to "�" without throwing. https://docs.python.org/3/library/codecs.html#error-handlers
Collaborator
|
Peux-tu me donner un peu plus d'info sur ce que tu as fait? Ca semble ajouter quand meme beaucoup de choses sans être super general. |
Author
|
Je viens de rajouter des détails dans la description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the iris for Rockefeller's Axicon. They wanted a Windows application to control their setup, so I built it in Python: https://github.com/BliqPhotonics/AxiconManager
The serial protocol of the iris is described in the following manual: https://www.uniblitz.com/wp-content/uploads/2021/03/ai25-direct-control-v1-2.pdf
Communication is done via an Arduino, because Uniblitz chose a somewhat bizarre configuration by routing the UART signals and 12V power directly via the pins of a USB3 port 🤨 : https://github.com/PhilCS/PyHardwareLibrary/tree/uniblitz/hardwarelibrary/irises/driverAI25
For the few commits unrelated to the iris, it's simply to fix two bugs I identified: 1. Avoid a
UnicodeDecodeErrorwhen the serial buffers contain parasitic non-ASCII bytes, and 2. Fix the brokenflush()method ofDebugPort.